"Will it make using some file sharing such as email and photo transferring easier?"

No, Firefox Sync doesn't handle that type of data; doesn't "do" email, but will access webmail where your email would be stored and images would be stored in the operating system.

Sync will synchronize these types of Firefox data - Bookmarks. Browsing History, Tabs, Passwords, Preferences, and Add-ons.

You indicated it would share certain files and images. I may have unknowingly already synced my devices as I have the same banking data, passwords, etc. on both of them ?? When I delete emails from my android they are deleted from my laptop in box also. In any case would it hurt to sync these together and also M.S. asks me to access the cloud and "one note" which I am not familiar with..... the cloud I understand but "one note" I do not. As you can surmise I am not all that hip to the web and all the offerings it has. Please forgive my ignorance.

https://en.wikipedia.org/wiki/Webmail

That email isn't on your devices if you are using Firefox. So when you delete an email from your webmail service provider, that email can't be viewed any longer from any device - it's gone.

https://en.wikipedia.org/wiki/Cloud_storage "Cloud storage" in general is completely different than what Sync does for Firefox. One Note does cloud storage.

Cloud storage can be used for a variety of purposes. As as "backup" service for your data or for sharing documents for access by a number of users who might be working on the same project (collaborating) and need to access those documents for proof-reading or editing.

As far as Passwords go, yes your Passwords could have been synced already; that data type is set as a default when the user first sets up Sync. Bookmarks and History are also default settings. So unless you changed those settings when you set up Sync, that is the data that would have been "synced".

As far as banking history goes, it is best to use Private Browsing mode when "banking", so that Firefox doesn't save that browsing history at all. Sync won't make your browsing history any more vulnerable than it might be on each device. IOW, someone using your PC in your absence without needing to log in to that device.

Thank you for your helpful advise. As a side note do you personally have all your devises sync'ed. Guy at geel squad said he did not as he worried that a failure on one might result in a failure in all.  ? ? ? Way off topic but any thoughts on this.....I have tried everything that I could see on most of the help sites, fircontrol panel did noting.e fox, m.s. etc. to delete the hover to enter function on my devise. i.e. if I just position my mouse pointer over a go / no go, or enter / delete option button, my machine enters that key without my yes or no key press. Using the enable and disable key in the control panel did nothing.

I don't currently have multiple devices, but I have used Sync in the past when I did have more than one PC / laptop. (No need for a "smart phone", a basic "feature" phone works fine for me.) There are limitations with Sync as with all software, but overall it does work as designed. Biggest problem is that the user documentation is poor to non-existent.

Anything that someone at GeekSquad says needs to be questioned, IMO. Sounds like a lack of knowledge for any software that wasn't made by Microsoft (or Apple).